Differential D21054

use the proper icons
AbandonedPublic
Actions

Authored by hansl on May 6 2019, 8:12 PM.

Details

Reviewers
mutlaqja
Summary

use the proper icons

Diff Detail

Repository
R321 KStars
Branch
HL-smallfix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11613
Build 11631: arc lint + arc unit
hansl created this revision.May 6 2019, 8:12 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 6 2019, 8:13 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
hansl requested review of this revision.May 6 2019, 8:13 PM
mutlaqja accepted this revision.May 6 2019, 10:02 PM

Thanks! first patch!

This revision is now accepted and ready to land.May 6 2019, 10:02 PM
mutlaqja added a comment.May 6 2019, 10:03 PM

But it failed to merge due to this:

remote: Audit failure - Commit e59b4888d596b663985813a506397fdad0dcd4db - Non-full name: d33psky

So you need to specify full real name in Arcanist.

hansl added a comment.May 7 2019, 8:38 PM

about 'Non-full name' which name do I need to specify and where and how ?
I do not see it in arc get-config nor in https://secure.phabricator.com/book/phabricator/article/arcanist/

mutlaqja added a comment.May 8 2019, 4:51 AM

Maybe it's in your git config? like the git Full name?

And btw, the change is not correct. For ALERT, it should be security-low.

hansl added a comment.May 11 2019, 11:11 AM

I see, right. OK. now this differential D21054 can be deleted. How do I do that ?

mutlaqja resigned from this revision.May 11 2019, 11:13 AM

well, I am resigning from this revision.. I'm not sure on your side what you need to do. Is this close or abandoned?

This revision now requires review to proceed.May 11 2019, 11:13 AM
hansl abandoned this revision.May 11 2019, 12:23 PM

Revision Contents
Changeset List

Diff 57681

View Options

kstars/ekos/scheduler/scheduler.cpp

Loading...