Differential D21040

Update according to review request.
ClosedPublic
Actions

Authored by andreas on May 5 2019, 9:30 PM.

Details

Reviewers
sars
Summary

Cleaned indentation and updated author info.

Diff Detail

Repository
R40 Kate
Branch
symbolviewer_xml_patch_after_review (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11582
Build 11600: arc lint + arc unit
andreas created this revision.May 5 2019, 9:30 PM
Restricted Application added a project: Kate. · View Herald TranscriptMay 5 2019, 9:30 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
andreas requested review of this revision.May 5 2019, 9:30 PM
sars accepted this revision.May 6 2019, 6:47 AM
sars added a subscriber: sars.

I guess there was some kind of arcanist mistake when this became a separate review request and not an update to D21024 (Rudimentary xml/html parser for symbolviewer plugin)

Please commit as one commit with the original title and description (or tell me if you do not have access).

This revision is now accepted and ready to land.May 6 2019, 6:47 AM
andreas added a comment.May 6 2019, 6:58 PM

Sorry (first time I am using this).
I commited an update of the original branch with same message.
I think I don't have access to land it (fatal: remote error: service not enabled: /kate).
Would be great if you could do it.

sars closed this revision.May 13 2019, 6:44 PM

The change was submitted in the original pull request

Revision Contents
Changeset List

PathPackages
Maddons/symbolviewer/xml_parser.cpp (176 lines)

Diff 57619

View Options

addons/symbolviewer/xml_parser.cpp

Loading...