Rudimentary xml/html parser for symbolviewer plugin
ClosedPublic

Authored by andreas on May 4 2019, 8:06 PM.

Details

Summary

Added a single new source file xml_parser.cpp based on xslt_parser.cpp to produce a
symbol view for xml and html files. Updated existing symbolviewer files. This stretches the
concept of symbolviewer a bit (what is a function or a macro in html), but it is useful for
some editing tasks.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
andreas created this revision.May 4 2019, 8:06 PM
Restricted Application added a project: Kate. · View Herald TranscriptMay 4 2019, 8:06 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
andreas requested review of this revision.May 4 2019, 8:06 PM
sars requested changes to this revision.May 5 2019, 7:58 AM
sars added a subscriber: sars.

Hi,

Good addition :)

Please update the copyright header to reflect that the file is based on the xslt parser written by jiri Tyr and add yourself to the copyright.

The indentation style in the original parsers are... strange... ;) Since this is basically a new file, we could use the kde frameworks coding style. I'm not insisting on it tho.

This revision now requires changes to proceed.May 5 2019, 7:58 AM
andreas updated this revision to Diff 57677.May 6 2019, 6:47 PM

Added a single new source file xml_parser.cpp based on xslt_parser.cpp to produce a
symbol view for xml and html files. Updated existing symbolviewer files. This stretches the
concept of symbolviewer a bit (what is a function or a macro in html), but it is useful for
some editing tasks.

sars accepted this revision.May 13 2019, 6:29 PM
This revision is now accepted and ready to land.May 13 2019, 6:29 PM
Closed by commit R40:cd5477a7ec82: Rudimentary xml/html parser for symbolviewer plugin (authored by Andreas Hohenegger <hohenegger@gmail.com>, committed by sars). · Explain WhyMay 13 2019, 6:40 PM
This revision was automatically updated to reflect the committed changes.