Differential D21022

services/test: Fix test
ClosedPublic
Actions

Authored by aspotashev on May 4 2019, 6:44 PM.

Details

Reviewers
elvisangelaccio
sitter
Group Reviewers
Dolphin
Commits
R318:7bc3b748b36b: services/test: Fix test

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aspotashev created this revision.May 4 2019, 6:44 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMay 4 2019, 6:44 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
aspotashev requested review of this revision.May 4 2019, 6:44 PM
elvisangelaccio added a comment.May 5 2019, 9:23 AM

What are we fixing here? The test does not fail for me (neither does on the CI).

aspotashev added a comment.May 5 2019, 3:12 PM

The original test did not verify the correctness of servicemenuinstallation: even if servicemenuinstallation is unable to create installed_file, the test would succeed.

elvisangelaccio added a comment.May 5 2019, 3:53 PM

I see, please write this information in the commit message.

aspotashev updated this revision to Diff 57732.May 7 2019, 7:00 PM

update commit message

sitter accepted this revision.May 8 2019, 11:34 AM
This revision is now accepted and ready to land.May 8 2019, 11:34 AM
Closed by commit R318:7bc3b748b36b: services/test: Fix test (authored by aspotashev). · Explain WhyMay 8 2019, 12:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 57756

View Options

src/settings/services/test/service_menu_installation_test.rb

Loading...