KCalCore : Clang-Tidy performance-unnecessary-copy-init fixes
ClosedPublic
Actions

Authored by winterz on May 4 2019, 4:21 PM.

Details

Reviewers

vkrause
dvratil

Commits

Summary

fixed unnecessary copy initialization , found by clang-tidy

Test Plan

make test still works

Repository

R172 KCalendar Core

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

winterz requested review of this revision.May 4 2019, 4:21 PM

Looks safe to me, the const ref changes only seem to refer to containers that aren't changed afterwards.

This revision is now accepted and ready to land.May 5 2019, 7:39 AM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	57553			May 4 2019, 4:20 PM	★	★
Diff 2	57593	b8b0e6e	R172:6ec370096c1ab0d55b7e208335435b15f3773c98	May 5 2019, 1:44 PM	★	★