Differential D2095

Don't show twice message widgets
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 5 2016, 8:15 PM.

Details

Reviewers
rthomsen
Commits
R36:50f0cbb42dd2: part: hide wrongly shown message widgets
Summary

If we use a global message widget in Part, we don't need to create it and add
it to the layout every time. This implies that message widgets are not "appended"
anymore below the previous one.

Test Plan

Create a new archive twice (without adding files).

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 4970.Jul 5 2016, 8:15 PM
elvisangelaccio retitled this revision from to Don't show twice message widgets.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptJul 5 2016, 8:15 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen edited edge metadata.Jul 6 2016, 4:31 PM

It would be nice to make the messagewidget disappear when the user adds a file. Can you implement this in the same diff?

elvisangelaccio added a comment.Jul 6 2016, 5:11 PM
In D2095#38806, @rthomsen wrote:

It would be nice to make the messagewidget disappear when the user adds a file. Can you implement this in the same diff?

I was planning to do another diff, but I guess I can do it here as well.

elvisangelaccio updated this revision to Diff 4999.Jul 7 2016, 9:09 AM
elvisangelaccio edited edge metadata.
  • Hide message widget after adding files
rthomsen requested changes to this revision.Jul 8 2016, 2:46 PM
rthomsen edited edge metadata.

The KMessageWidget remains visible if the user opens another archive before adding any files.

This revision now requires changes to proceed.Jul 8 2016, 2:46 PM
elvisangelaccio updated this revision to Diff 5024.Jul 8 2016, 3:43 PM
elvisangelaccio edited edge metadata.
  • Also hide message widget when opening another archive
rthomsen accepted this revision.Jul 8 2016, 3:48 PM
rthomsen edited edge metadata.

Ship it! :)

This revision is now accepted and ready to land.Jul 8 2016, 3:48 PM
Closed by commit R36:50f0cbb42dd2: part: hide wrongly shown message widgets (authored by elvisangelaccio). · Explain WhyJul 8 2016, 3:57 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:50f0cbb42dd2: part: hide wrongly shown message widgets.

Revision Contents
Changeset List

PathPackages
Mpart/part.h (2 lines)
Mpart/part.cpp (27 lines)

Diff 5025

View Options

part/part.h

Loading...
View Options

part/part.cpp

Loading...