Differential D20949

[EPubGenerator] Avoid crashes due to bogus wrapping of content in table
ClosedPublic
Actions

Authored by bruns on May 1 2019, 10:56 PM.

Details

Reviewers
aacid
Group Reviewers
Okular
Commits
R223:9f98c010691e: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table
Summary

QTextDocument chokes badly when a some documents are wrapped inside
a table, returning e.g. a pagecount of -41292 afterwards.

On the downside, this removes any padding from the page. On the upside,
it removes any padding from the page.

BUG: 406738
BUG: 407140
CCBUG: 406116

Diff Detail

Repository
R223 Okular
Branch
fix_epub
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11427
Build 11445: arc lint + arc unit
bruns created this revision.May 1 2019, 10:56 PM
Restricted Application added a project: Okular. · View Herald TranscriptMay 1 2019, 10:56 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
bruns requested review of this revision.May 1 2019, 10:56 PM
bruns updated this revision to Diff 57352.May 1 2019, 11:12 PM

remove unrelated code from patch

bruns edited the summary of this revision. (Show Details)May 1 2019, 11:20 PM
aacid accepted this revision.May 22 2019, 10:24 PM
aacid added a subscriber: aacid.

ok, i guess, the padding was a bit arbitrary and to first page only anyway ^_^

This revision is now accepted and ready to land.May 22 2019, 10:24 PM
Closed by commit R223:9f98c010691e: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table (authored by bruns, committed by aacid). · Explain WhyMay 22 2019, 10:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mgenerators/epub/converter.cpp (8 lines)

Diff 57350

View Options

generators/epub/converter.cpp

Loading...