HCG color model - second attempt for implemenation
AbandonedPublic

Authored by woltherav on Jul 5 2016, 7:37 PM.

Details

Summary
Test Plan
  • Test HCG sliders
  • Test wheel, square, triangle color picker

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
acterhd updated this revision to Diff 4967.Jul 5 2016, 7:37 PM
acterhd retitled this revision from to HCG color model - second attempt for implemenation.
acterhd updated this object.
acterhd edited the test plan for this revision. (Show Details)
acterhd set the repository for this revision to R37 Krita.
acterhd added a project: Krita: Next Features.
acterhd updated this object.
acterhd updated this revision to Diff 4968.Jul 5 2016, 8:04 PM
acterhd updated this revision to Diff 4969.Jul 5 2016, 8:11 PM
acterhd updated this object.Jul 5 2016, 8:19 PM
acterhd updated this revision to Diff 5062.Jul 10 2016, 4:47 PM

Tried to fix some issues

acterhd updated this revision to Diff 5063.Jul 10 2016, 5:07 PM
acterhd updated this object.
acterhd updated this revision to Diff 5065.Jul 10 2016, 5:27 PM
acterhd updated this revision to Diff 5066.Jul 10 2016, 5:30 PM
acterhd updated this revision to Diff 5480.Jul 24 2016, 6:44 PM

Removed sliders support

I plans add support for sliders in another patch.

dkazakov edited edge metadata.Jul 25 2016, 7:47 AM

Hi, @acterhd!

I tried to apply your patch to master but I have a lot of patch conflicts. What branch do you use for developing?

Я не помню какая ветка. Помню что.

git clone git://anongit.kde.org/krita

Try git apply --reject --whitespace=fix "yourdiff"

It has a lot of rejected hunks. I cannot test it.

acterhd updated this revision to Diff 5487.Jul 25 2016, 1:00 PM
acterhd edited edge metadata.

I tried to fix rejection

I looked version: 3.0.1 alpha.

Hi, Alexey!

Please use master branch for making the patch. I cannot apply it to anything. Neither to master, nor to krita/3.0

Show me errors.

This is impossible! Better if somebody rewrite HCG. who good know C++ and indentation.
Я сделал всевозможное...

This comment was removed by acterhd.

The latest patch can be applied with:

tr -d '\r' < D2094.diff > D2094_fixed.diff
git apply --whitespace=fix D2094_fixed.diff
acterhd rescinded a token.Jul 25 2016, 5:45 PM
acterhd awarded a token.

Here is the fixed patch:

Though I couldn't activate it. It seems like when I change the color model of the color selector nothing changes.And not only for HCG, but also for any other color model.

acterhd updated this revision to Diff 5505.Jul 26 2016, 1:42 PM

Fix my Dmitry.

dkazakov requested changes to this revision.Jul 6 2017, 11:47 AM

As fas as I can tell the patch was abandoned by the author. It needs documentation and discussion with painters about the usecases.

This revision now requires changes to proceed.Jul 6 2017, 11:47 AM
woltherav commandeered this revision.Dec 7 2017, 3:22 PM
woltherav abandoned this revision.
woltherav edited reviewers, added: acterhd; removed: woltherav.