[Kickoff] Sort Favorites in-view
ClosedPublic

Authored by broulik on Jul 4 2016, 8:47 PM.

Details

Summary

Similar to what Kicker and Task Manager already have. Code adapted from Kicker.
Provides a much more hands-on experience when sorting favorites.

Test Plan

Works. It does not scroll the view down automatically as you drop but I don't think Kickoff did that previously either.
Verified that in unlockedDesktop=false Plasma (Kiosk) we cannot sort favorites.

(The DragHelper ungrab is so it doesn't swallow clicks like we already do in Task Manager. Will commit separately)

Video: https://www.youtube.com/watch?v=-ULgaGbnl2o

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4951.Jul 4 2016, 8:47 PM
broulik retitled this revision from to [Kickoff] Sort Favorites in-view.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 4 2016, 8:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
colomar added a subscriber: colomar.Jul 4 2016, 8:50 PM

+1, good improvement!

I fear that many users won't discover it, but we need a more global solution for that problem anyway.

davidedmundson accepted this revision.Jul 11 2016, 1:40 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jul 11 2016, 1:40 PM
This revision was automatically updated to reflect the committed changes.