Fix mainwindow titles: do not prepend ourselves the appname
ClosedPublic

Authored by kossebau on Jul 4 2016, 6:10 PM.

Details

Summary

The appname is appended by the platform (integration) usually,
so that only results in duplication.

Also fix code to now show the map in the title on start.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 4943.Jul 4 2016, 6:10 PM
kossebau retitled this revision from to Fix mainwindow titles: do not prepend ourselves the appname.
kossebau updated this object.
kossebau added reviewers: Marble, rahn, nienhueser.
nienhueser edited edge metadata.Jul 5 2016, 3:16 AM

I kinda wonder about the "usually" in the description, and expect at least Windows not to do anything remotely useful. Any idea what happens there?

http://doc.qt.io/qt-5/qwidget.html#windowTitle-prop says:
"
On some desktop platforms (including Windows and Unix), the application name (from QGuiApplication::applicationDisplayName) is added at the end of the window title, if set. This is done by the QPA plugin, so it is shown to the user, but isn't part of the windowTitle string.
"
So Windows should be fine. No idea though about macOS though. But given that QPA is supposed to deal with that, I would also rely on that to do some proper handling.

rahn edited edge metadata.Jul 5 2016, 10:40 AM

Looks good to me :)

nienhueser accepted this revision.Jul 9 2016, 3:26 PM
nienhueser edited edge metadata.

Thanks for the explanation, please push then :-)

This revision is now accepted and ready to land.Jul 9 2016, 3:26 PM
This revision was automatically updated to reflect the committed changes.