Differential D2087

Drop search and routing results on planet change (QWidget tools only)
ClosedPublic
Actions

Authored by kossebau on Jul 4 2016, 4:12 PM.

Details

Reviewers
nienhueser
rahn
Group Reviewers
Marble
Commits
R34:d69a3c04a293: Drop search and routing results on planet change (QWidget tools only)
Summary

A more complete solution could perhaps cache the results per planet.
So when switching back to a planet, the last search & routing results
could be used again.

Test Plan

Switching between differet themes for the same planet keeps current
search & routing results. Switching planet drops the results.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 4942.Jul 4 2016, 4:12 PM
kossebau retitled this revision from to Drop search and routing results on planet change (QWidget tools only).
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: Marble, rahn, nienhueser.
nienhueser accepted this revision.Jul 4 2016, 6:27 PM
nienhueser edited edge metadata.

Looks good, please push.

This revision is now accepted and ready to land.Jul 4 2016, 6:27 PM
Closed by commit R34:d69a3c04a293: Drop search and routing results on planet change (QWidget tools only) (authored by kossebau). · Explain WhyJul 4 2016, 8:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4950

View Options

src/lib/marble/SearchWidget.h

Loading...
View Options

src/lib/marble/SearchWidget.cpp

Loading...
View Options

src/lib/marble/routing/RoutingWidget.h

Loading...
View Options

src/lib/marble/routing/RoutingWidget.cpp

Loading...