Fix some clazy warning
ClosedPublic

Authored by mlaurent on Apr 25 2019, 9:11 PM.

Details

Summary

fix clazy warning

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Apr 25 2019, 9:11 PM
Restricted Application added a project: Okular. · View Herald TranscriptApr 25 2019, 9:11 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
mlaurent requested review of this revision.Apr 25 2019, 9:11 PM
aacid added inline comments.Apr 25 2019, 9:19 PM
core/fileprinter.h
92 ↗(On Diff #56998)

This breaks ABI

mlaurent updated this revision to Diff 57003.Apr 26 2019, 5:25 AM

Fix comment gave by albert

This comment was removed by mlaurent.

Ok albert send me an email in private :)
he will look at it in several days :)
tha,ks :)

(I didn't have internet access before to see his email :)

aacid accepted this revision.Tue, May 21, 8:36 PM

Please revert the QStringLiteral with utf8 inside, after that you can commit if you're convince there will be no regressions :)

autotests/parttest.cpp
258

QStringliteral is broken on windows with non ascii chars, please turn this back to QString::fromUtf8 so tests don't start failing.

This revision is now accepted and ready to land.Tue, May 21, 8:36 PM
nicolasfella added inline comments.
autotests/parttest.cpp
258

Might be worth a comment so the next person knows?

This revision was automatically updated to reflect the committed changes.