Add fullscreen mode to kmahjongg
ClosedPublic

Authored by krippendorf on Apr 25 2019, 8:43 PM.

Details

Reviewers
mlaurent
aacid
Group Reviewers
KDE Games
Summary

Adds just a fullscreen window state to kmahjongg. For now the feature won't be saved over session. This will be implemented in future versions.

Diff Detail

Repository
R403 KMahjongg
Lint
Lint Skipped
Unit
Unit Tests Skipped
krippendorf created this revision.Apr 25 2019, 8:43 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptApr 25 2019, 8:43 PM
krippendorf requested review of this revision.Apr 25 2019, 8:43 PM
aacid added a subscriber: aacid.Apr 25 2019, 9:23 PM
aacid added inline comments.
src/kmahjongg.cpp
173

use KStandardAction::fullScreen ? https://api.kde.org/frameworks/kconfigwidgets/html/namespaceKStandardAction.html#a0e30d17570d5b886e97b1f2cf34ef900

that way you don't have to set the text (which is wrong) nor the icon yourself

mlaurent requested changes to this revision.Fri, Apr 26, 6:04 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/kmahjonggui.rc
17

You need to increase rc file version (see top of file).
Sorry by we don't have context here to show correct line.
Using arc is a good method for reviewing patch
Thanks

This revision now requires changes to proceed.Fri, Apr 26, 6:04 AM

Change to KStandardAction & Revision increase in rc file

mlaurent requested changes to this revision.Fri, Apr 26, 11:17 AM
mlaurent added inline comments.
src/kmahjongg.cpp
172

Please use new connect api here.

This revision now requires changes to proceed.Fri, Apr 26, 11:17 AM
krippendorf marked an inline comment as done.
mlaurent requested changes to this revision.Mon, Apr 29, 4:48 AM
mlaurent added inline comments.
src/kmahjongg.cpp
195

Signal emitted is a clicked(bool)

> change it to toggleFullscreen(bool fullScreen)

> not necessary to use m_fullscreenAction->isChecked()

This revision now requires changes to proceed.Mon, Apr 29, 4:48 AM

Forget to commit last changes

mlaurent accepted this revision.Tue, Apr 30, 12:05 PM

for me it's ok.

This revision is now accepted and ready to land.Tue, Apr 30, 12:05 PM
aacid accepted this revision.Tue, Apr 30, 9:35 PM

Do you have commit access or you want that we commit for you ?

Do you have commit access or you want that we commit for you ?

I have access thanks.

krippendorf closed this revision.Sat, May 4, 11:16 AM