Differential D20829

[Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI
ClosedPublic
Actions

Authored by ngraham on Apr 25 2019, 8:02 PM.

Details

Reviewers
filipf
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R120:e39aed6f167f: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI
Summary
  • Port to QQC2+Kirigami FormLayout style
  • Adjust some strings to be more natural
  • Use radio buttons instead of a two-item combobox
Test Plan

Everything works.

Diff Detail

Repository
R120 Plasma Workspace
Branch
modernize-calendar-widget-settings-window (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11235
Build 11253: arc lint + arc unit
ngraham created this revision.Apr 25 2019, 8:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 25 2019, 8:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 25 2019, 8:02 PM
filipf accepted this revision.Apr 25 2019, 8:11 PM
filipf added a subscriber: filipf.
filipf added inline comments.
applets/calendar/package/contents/ui/configGeneral.qml
27

trailing space

50

Compact version is maybe a bit vague, but I can't think of anything better honestly.

This revision is now accepted and ready to land.Apr 25 2019, 8:11 PM
ngraham updated this revision to Diff 56995.Apr 25 2019, 8:23 PM
ngraham marked an inline comment as done.

Delete trailing space

ngraham added inline comments.Apr 25 2019, 8:24 PM
applets/calendar/package/contents/ui/configGeneral.qml
50

Yeah me neither. :/

Closed by commit R120:e39aed6f167f: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI (authored by ngraham). · Explain WhyApr 25 2019, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56993

View Options

applets/calendar/package/contents/config/config.qml

Loading...
View Options

applets/calendar/package/contents/ui/configGeneral.qml

Loading...