Differential D20788

Reset model when there are new available connections
ClosedPublic
Actions

Authored by McPain on Apr 24 2019, 1:49 PM.

Details

Reviewers
jgrulich
Commits
R116:4cb1e69c1a61: Reset model when there are new available connections
Summary

BUG: 406765

NetworkManager will remove all connections (at least wireless) and then add them again.
When user creates a new connection and clicks "Disconnect" button before adding connections back, the one which user tried to connect to will disappear from list of available, and it will become impossible to reactivate it from applet.

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
McPain created this revision.Apr 24 2019, 1:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 24 2019, 1:49 PM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Apr 24 2019, 1:49 PM
jgrulich accepted this revision.Apr 25 2019, 6:31 AM
This revision is now accepted and ready to land.Apr 25 2019, 6:31 AM
McPain planned changes to this revision.Apr 29 2019, 6:04 AM

The patch "as-is" is broken.
I had reports about resetting model right after clicking "Connect" button - model resets and there are no connection attempts.

jgrulich added a comment.Apr 29 2019, 6:21 AM

I think resetting the model might not be necessary, when addAvailableConnection() is called, it then updates item with a new available connection, which invalidates the filter anyway or at least it should.

McPain added a comment.Apr 29 2019, 12:39 PM
In D20788#457772, @jgrulich wrote:

I think resetting the model might not be necessary, when addAvailableConnection() is called, it then updates item with a new available connection, which invalidates the filter anyway or at least it should.

For some unknown reason, it doesn't.
Trying to figure out what happens and why exactly it happens.

McPain requested review of this revision.Apr 29 2019, 2:51 PM

Tomorrow I'll land this patch, but I submitted another one

https://phabricator.kde.org/D20900

This revision is now accepted and ready to land.Apr 29 2019, 2:51 PM
jgrulich requested changes to this revision.Apr 29 2019, 2:54 PM

You said it's broken so I would preffer not landing a broken patch.

This revision now requires changes to proceed.Apr 29 2019, 2:54 PM
McPain added a comment.Apr 29 2019, 3:04 PM
In D20788#458047, @jgrulich wrote:

You said it's broken so I would preffer not landing a broken patch.

I thought it was a regression when I applied this patch. Could reproduce an error (see D20900) without it

jgrulich accepted this revision.Apr 30 2019, 6:34 AM
This revision is now accepted and ready to land.Apr 30 2019, 6:34 AM
Closed by commit R116:4cb1e69c1a61: Reset model when there are new available connections (authored by McPain). · Explain WhyApr 30 2019, 1:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibs/models/networkmodel.cpp (2 lines)

Diff 57265

View Options

libs/models/networkmodel.cpp

Loading...