Differential D20733

[libkwineffects] Use fully qualified type name for signal
ClosedPublic
Actions

Authored by broulik on Apr 22 2019, 11:37 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:97c3cb73ffdc: [libkwineffects] Use fully qualified type name for signal
Summary

Qt Script Engine isn't particularly smart at resolving namespaces.

Test Plan

5.15 branch
Connecting to windowFullScreenChanged previously resulted in an error

QScriptEngine: Unable to handle unregistered datatype 'EffectWindow*' when invoking handler of signal KWin::EffectsHandlerImplX11::windowFullScreenChanged(EffectWindow*)

With this patch it works

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 22 2019, 11:37 AM
Restricted Application added a project: KWin. · View Herald TranscriptApr 22 2019, 11:37 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Apr 22 2019, 11:37 AM
zzag accepted this revision.Apr 22 2019, 12:30 PM
This revision is now accepted and ready to land.Apr 22 2019, 12:30 PM
Closed by commit R108:97c3cb73ffdc: [libkwineffects] Use fully qualified type name for signal (authored by broulik). · Explain WhyApr 23 2019, 9:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibkwineffects/kwineffects.h (6 lines)

Diff 56803

View Options

libkwineffects/kwineffects.h

Loading...