Details
- Reviewers
nienhueser rahn
Diff Detail
- Repository
- R34 Marble
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| src/lib/marble/routing/VoiceNavigationModel.cpp | ||
|---|---|---|
| 371 | This seems hard to understand. Can you introduce several boolean variables with speaking names that split it up in more readable pieces? What happened to the lastDistance == 0 case? | |
| src/lib/marble/routing/VoiceNavigationModel.cpp | ||
|---|---|---|
| 371 | If I'm not wrong, the lastDistance == 0 case signifies the case of the user just coming to a new segment, right? I was thinking of not handling that case anymore because now we want the navigation to speak only when he has reached a distance instead of immediately. | |
| src/lib/marble/routing/VoiceNavigationModel.cpp | ||
|---|---|---|
| 371 | If I'm not wrong, the lastDistance == 0 check signifies the case of the user just coming to a new segment, right? I was thinking of not handling that case anymore because now we want the navigation to speak only when user has traveled a minimum distance instead of immediately after coming to the segment. | |
Looks good.
| src/lib/marble/routing/VoiceNavigationModel.cpp | ||
|---|---|---|
| 371 | What is the m_lastDistanceTraversed < 40 check for? | |
| src/lib/marble/routing/VoiceNavigationModel.cpp | ||
|---|---|---|
| 371 | I followed the same logic here as for bool const turn's "d->m_lastDistance > 75 && distanceManuever <= 75" part, that is, when the guy had not covered 40 metres before, but just crossed that distance right now. | |