Differential D20694

Use regular stat when resolving a symlink
ClosedPublic
Actions

Authored by meven on Apr 20 2019, 10:01 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:dfbc18403297: Use regular stat when resolving a symlink
Summary

Before f3b0f220a78d4e5a5b94b46e931779d755ac19ce when getting the details of a symlink a regular QT_STAT mimicking stat() was used.

Test Plan

ctest

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Apr 20 2019, 10:01 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 20 2019, 10:01 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Apr 20 2019, 10:01 AM
dfaure accepted this revision.Apr 20 2019, 10:06 AM

Glad that the unittest caught an actual bug for once :-)

Yes we'd all love pre-merge CI checks, but that won't happen with phabricator. I hear rumours of a migration to gitlab at some point, which should surely help.

This revision is now accepted and ready to land.Apr 20 2019, 10:06 AM
bcooksley added a subscriber: bcooksley.Apr 20 2019, 10:15 AM

The Gitlab migration is in planning and preparation stages, so should happen sometime in the next couple of months.

meven added a comment.Apr 20 2019, 10:17 AM
In D20694#453252, @bcooksley wrote:

The Gitlab migration is in planning and preparation stages, so should happen sometime in the next couple of months.

I can't wait for gitlab migration.
phabricator is quite nice but not as common as a git-PR based workflow.

Closed by commit R241:dfbc18403297: Use regular stat when resolving a symlink (authored by meven). · Explain WhyApr 20 2019, 10:17 AM
This revision was automatically updated to reflect the committed changes.
meven added a comment.Apr 20 2019, 10:19 AM

https://build.kde.org/view/OS - Windows/job/Frameworks/job/kio/job/kf5-qt5 SUSEQt5.10/95 Will confirm if this is fixed.

dfaure added a comment.Apr 20 2019, 10:49 AM

I fixed them ;-)

meven added a comment.Apr 20 2019, 11:02 AM
In D20694#453296, @dfaure wrote:

I fixed them ;-)

Nice back to stable tests!

Revision Contents
Changeset List

PathPackages
Msrc/ioslaves/file/file.cpp (16 lines)

Diff 56618

View Options

src/ioslaves/file/file.cpp

Loading...