Fix test KDirListerTest::testRenameItem
AbandonedPublic
Actions

Authored by meven on Apr 20 2019, 7:20 AM.

Details

Reviewers

Group Reviewers

Summary

The test was buggy to begin with : the wrong refreshedItems slot was used and would not refresh the expected m_refreshedItems2.

Repository

R241 KIO

Branch

fix-etst

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11040
Build 11058: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

meven requested review of this revision.Apr 20 2019, 7:20 AM

dfaure requested changes to this revision.Apr 20 2019, 8:25 AM

dfaure added inline comments.

autotests/kdirlistertest.cpp
549	I don't see a signal called refreshItems2 anywhere.

This revision now requires changes to proceed.Apr 20 2019, 8:25 AM

I mixed up refreshItems and slotRefreshItems.
My fix is nonsense

			Path	Packages
M			autotests/kdirlistertest.cpp (5 lines)

Commit	Tree	Parents	Author	Summary	Date
3d871f428031	9eea1184eeaf	f8328c008e01	Méven Car	Fix test KDirListerTest::testRenameItem (Show More…)	Apr 20 2019, 7:17 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56610	f8328c0		Apr 20 2019, 7:20 AM	★	★