Differential D20679

Hide unfinished vector pattern fill feature
ClosedPublic
Actions

Authored by gernene on Apr 19 2019, 2:15 AM.

Details

Reviewers
rempt
Group Reviewers
VDG
Krita
Summary

I hid vector pattern fill (unfinished) by adding a bool property (visible: false) to the respective ui file.
This is intended to prevent Krita users from mistaking the unfinished feature for a bug.
BUG: 403140
Note:
The visible property can no longer be added in newer QtCreator/Designer versions.
The setVisible(bool) function also seems to be disabled.
To remove/add the visible property, please remove the respective lines in a regular text-editor.

Test Plan

See bug 403140 reproduction instructions

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11022
Build 11040: arc lint + arc unit
gernene requested review of this revision.Apr 19 2019, 2:15 AM
gernene created this revision.
vanyossi added a reviewer: Krita.Apr 19 2019, 2:18 AM
vanyossi set the repository for this revision to R37 Krita.
vanyossi added a project: Krita.
gernene edited the summary of this revision. (Show Details)Apr 19 2019, 2:27 AM
gernene updated this revision to Diff 56575.Apr 19 2019, 2:42 AM

Use setVisible(bool) to hide vector pattern fill

ngraham added a subscriber: ngraham.Apr 19 2019, 4:49 AM

If you tag VDG, it's nice to add screenshots. :)

rempt accepted this revision.Apr 19 2019, 7:06 AM
This revision is now accepted and ready to land.Apr 19 2019, 7:06 AM
scottpetrovic closed this revision.Apr 23 2019, 1:15 PM
scottpetrovic added a subscriber: scottpetrovic.

I just pushed this out and made @gernene the author.

Closing this ticket. We are using Gitlab now, so any future patches can go through that process.
https://invent.kde.org/kde/krita

Revision Contents
Changeset List

Diff 56575

View Options

libs/ui/widgets/KoFillConfigWidget.cpp

Loading...
View Options

libs/ui/widgets/KoFillConfigWidget.ui

Loading...