Differential D20665

use the base implementation hints
ClosedPublic
Actions

Authored by mart on Apr 18 2019, 2:44 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R296:d9a0365ccc49: use the base implementation hints
Summary

with latest kirigami master and kcmutils, the default size hints
of scrollablepage are correct

also don't show empty header/footer when not needed, which do extra
useless space

Test Plan

kcmshell5 kcm_fonts starts with proper size now

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Apr 18 2019, 2:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 18 2019, 2:44 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Apr 18 2019, 2:44 PM
ngraham retitled this revision from use the base implementation hints to Use the base implementation hints.Apr 18 2019, 2:48 PM
ngraham edited the summary of this revision. (Show Details)
mart updated this revision to Diff 56534.Apr 18 2019, 2:48 PM
mart retitled this revision from Use the base implementation hints to use the base implementation hints.
mart edited the summary of this revision. (Show Details)
  • remove visual debug
ngraham accepted this revision.Apr 18 2019, 2:50 PM
ngraham added a subscriber: ngraham.

+1 shipit!

This revision is now accepted and ready to land.Apr 18 2019, 2:50 PM
Closed by commit R296:d9a0365ccc49: use the base implementation hints (authored by mart). · Explain WhyApr 18 2019, 2:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56535

View Options

src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

Loading...