If the file says it has a longlink of more than int_max bytes, the resize would do nothing (since casting to int means a negative number) and we'd try writing on a bytearray of size 0
Details
Details
Diff Detail
Diff Detail
- Repository
- R243 KArchive
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10974 Build 10992: arc lint + arc unit
Comment Actions
+1 in general
| src/ktar.cpp | ||
|---|---|---|
| 241 | It could make sense to say that it's because of the maximum size longling can have in a comment. | |
| src/ktar.cpp | ||
|---|---|---|
| 241 | You mean also printing std::numeric_limits<int>::max() ? | |
| src/ktar.cpp | ||
|---|---|---|
| 241 | I meant in a comment, but yeah, it's on the warning already. | |