Implement set_window_geometry
ClosedPublic

Authored by davidedmundson on Apr 16 2019, 7:58 AM.

Details

Summary

Used by clients to say where their true window geometry is relative to
the buffer size. Important if a client has client side shadows which
shouldn't be included for positioning tasks.

Technically this should be double buffered, but for consistency with all
other XdgShell properties this will be a task left to ShellClient.

Test Plan

Unit test

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 16 2019, 7:58 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 16 2019, 7:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Apr 16 2019, 7:58 AM
zzag added a subscriber: zzag.Apr 16 2019, 8:22 AM

What about xdg_shell_unstable_v6?

zzag added inline comments.Apr 16 2019, 8:35 AM
src/server/xdgshell_interface.h
283

s/position/geometry/

src/server/xdgshell_stable_interface.cpp
524

The copy constructor is redundant (most likely a leftover I guess).

davidedmundson marked 2 inline comments as done.Apr 16 2019, 9:09 AM

What about xdg_shell_unstable_v6?

Code wise it's a super easy copy + paste.
I'm somewhat torn when it comes to adding new "features" to deprecated specs that I can't do real-world testing of.

Maybe we can revisit once I've done the kwin side?

zzag added a comment.Apr 16 2019, 9:15 AM

Maybe we can revisit once I've done the kwin side?

Sure.

marking inline comments as done

zzag accepted this revision.May 14 2019, 10:16 AM
This revision is now accepted and ready to land.May 14 2019, 10:16 AM
This revision was automatically updated to reflect the committed changes.