Differential D20536

Use consistent default Kickoff user icon
ClosedPublic
Actions

Authored by GB_2 on Apr 14 2019, 1:01 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R266:1c6e30d312c7: Use consistent default Kickoff user icon
Summary

Add the 22px default user icon that is used everywhere else.

Test Plan

Open Kickoff.

Diff Detail

Repository
R266 Breeze Icons
Branch
arcpatch-D20536_1
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11074
Build 11092: arc lint + arc unit
GB_2 created this revision.Apr 14 2019, 1:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 14 2019, 1:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
GB_2 requested review of this revision.Apr 14 2019, 1:01 PM
GB_2 updated this revision to Diff 56196.Apr 14 2019, 1:04 PM

Use symlinks instead of copying the icons

ngraham added a subscriber: ngraham.Apr 15 2019, 2:58 AM

This makes it inconsistent with the default user avatar shown in the Users KCM though. That's kinda odd.

GB_2 added a comment.Apr 15 2019, 3:09 AM
In D20536#450246, @ngraham wrote:

This makes it inconsistent with the default user avatar shown in the Users KCM though. That's kinda odd.

Ok, then we could rename that 128px icon to something different.

GB_2 updated this revision to Diff 56263.Apr 15 2019, 3:48 AM

Change name of blue user icon, will need to make a patch for user-manager too

ngraham accepted this revision.Apr 15 2019, 4:36 AM

+1, assuming D20564 is approved and lands.

This revision is now accepted and ready to land.Apr 15 2019, 4:36 AM
GB_2 updated this revision to Diff 56677.Apr 21 2019, 7:26 PM

Fix diff

Closed by commit R266:1c6e30d312c7: Use consistent default Kickoff user icon (authored by GB_2). · Explain WhyApr 21 2019, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 6 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 56677