Differential D2052

[autotests/integration] Simplify the cmake for creating a test
ClosedPublic
Actions

Authored by graesslin on Jun 30 2016, 6:40 AM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:1f2b47a83b07: [autotests/integration] Simplify the cmake for creating a test

Summary

A dedicated cmake function is added to create a test case. It takes
a NAME, the SRCS and additional LIBS.

Thus it's
integrationTest(NAME myTestCase SRCS test.cpp)

to create a standard integration test.

In addition kwin_wayland_test.cpp is compiled into a static library
to decrease the compile time a little bit.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 4865.Jun 30 2016, 6:40 AM

graesslin retitled this revision from to [autotests/integration] Simplify the cmake for creating a test.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJun 30 2016, 6:40 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

Maybe you could keep comments on what test is on..

This revision is now accepted and ready to land.Jun 30 2016, 7:01 AM

In D2052#37872, @bshah wrote:

Maybe you could keep comments on what test is on..

I removed them as they in 99 % of the cases don't have any further information than the name of the test binary.

graesslin added a dependent revision: D2053: [autotest/integration] Introduce a Test helper library to have less code duplication.Jun 30 2016, 3:03 PM

graesslin added a dependency: D2046: [autotests] Add a new test case which can verify the rendering of QPainter Scene.

Closed by commit R108:1f2b47a83b07: [autotests/integration] Simplify the cmake for creating a test (authored by graesslin). · Explain WhyJul 1 2016, 7:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/CMakeLists.txt (277 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4865	c3e8997		Jun 30 2016, 6:40 AM	★	★
Diff 2	4882	055e2b3	rKWIN1f2b47a83b07a07083db21a068ef69588c9d0887	Jul 1 2016, 7:00 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6af8c558a31e	b356aa85ee72	c3e8997607c8	Martin Gräßlin	[autotests/integration] Simplify the cmake for creating a test (Show More…)	Jun 30 2016, 6:37 AM

Status	Author	Revision
Closed	graesslin	D2053 [autotest/integration] Introduce a Test helper library to have less code duplication
Closed	graesslin	D2052 [autotests/integration] Simplify the cmake for creating a test
Closed	graesslin	D2046 [autotests] Add a new test case which can verify the rendering of QPainter Scene

Diff 4882

View Options

autotests/integration/CMakeLists.txt