Enable multi-tab-only shortcuts after restoring a multi-tab session from session management
Needs RevisionPublic

Authored by ahartmetz on Apr 13 2019, 9:46 PM.


Group Reviewers

The container's addView() method emits a signal viewAdded() that enables multi-tab QActions when the second tab is added. In fact, it seems a bit unnecessary that almost all calls of createView() are followed by addView()? There might be some cleanup potential there.

This patch is supposed to be a suggestion and base for discussion for just mentioned reasons.

Diff Detail

R319 Konsole
Lint Skipped
Unit Tests Skipped
ahartmetz created this revision.Apr 13 2019, 9:46 PM
Restricted Application added a project: Konsole. · View Herald TranscriptApr 13 2019, 9:46 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
ahartmetz requested review of this revision.Apr 13 2019, 9:46 PM
tcanabrava requested changes to this revision.Apr 26 2019, 11:40 AM

The proces of creation / destructiion / management of the views is a bit more complex. I'll gladly accept a patch but one that actually helps to clean the current behavior. This one just hides complexity.

This revision now requires changes to proceed.Apr 26 2019, 11:40 AM