Differential D20511

When not displaying rating, leave more room for song title in playlist
ClosedPublic
Actions

Authored by ngraham on Apr 13 2019, 3:52 PM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:358086c22289: When not displaying rating, leave more room for song title in playlist
Summary

Currently the Playlist's ratings widget reserves space for itself for unrated songs,
which causes song titles to get elided even when there's plenty of space.

This patch hides the ratings widget for unrated songs, allowing the song title label
to have more space and not be elides as often.

This could become a problem in the future if there is ever a desire to set ratings
interactively by clicking on the ratings widget, but that's not implemented so for now
there's no issue (and probably a hover-based UI could make sense for that anyway).

BUG: 406480

Test Plan

Now song titles for unrated songs have plenty of space, and rated songs display the same:

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham requested review of this revision.Apr 13 2019, 3:52 PM
ngraham created this revision.
mgallien accepted this revision.Apr 13 2019, 8:09 PM

Thanks

This revision is now accepted and ready to land.Apr 13 2019, 8:09 PM
Closed by commit R255:358086c22289: When not displaying rating, leave more room for song title in playlist (authored by ngraham). · Explain WhyApr 13 2019, 9:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/PlayListEntry.qml (2 lines)

Diff 56159

View Options

src/qml/PlayListEntry.qml

Loading...