Differential D20493

Introduce and use KArchiveDirectory::addEntryV2
ClosedPublic
Actions

Authored by aacid on Apr 12 2019, 1:38 PM.

Details

Reviewers
apol
Commits
R243:64f4f4dead08: Introduce and use KArchiveDirectory::addEntryV2
Summary

The original addEntry can delete the entry that is passed in, but we have no way to know
about it, so when that happens if we try to use the entry afterwards it will crash

This patch changes all the cases where addEntry was used and the entry passed to it is used later in the code

Test Plan

Broken file doesn't crash anymore

Diff Detail

Repository
R243 KArchive
Branch
arcpatch-D20493
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10769
Build 10787: arc lint + arc unit
aacid created this revision.Apr 12 2019, 1:38 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 12 2019, 1:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Apr 12 2019, 1:38 PM
aacid updated this revision to Diff 56065.Apr 12 2019, 1:43 PM

remove friend, don't need it with this current approach

apol accepted this revision.Apr 13 2019, 1:04 AM
This revision is now accepted and ready to land.Apr 13 2019, 1:04 AM
aacid closed this revision.Apr 13 2019, 9:09 AM

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/karchivedirectory.h (7 lines)

Diff 56065

View Options

src/karchivedirectory.h

Loading...