[KDE Platform Theme] Set application layoutDirection based on locale
AbandonedPublic

Authored by broulik on Jun 29 2016, 8:27 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma: Design
Plasma
Summary

This ensures that when starting the application with eg. Hebrew locale, the application is mirrored.

Qt does not seem to do this automatically but instead apparently wants you to include a QT_LAYOUT_DIRECTION string translated as either rtl or ltr in your app.

Test Plan

LC_ALL=ar dolphin ← dolphin was reversed, before it was not
LC_ALL=he dolphin ← dolphin was reversed, before it was not
dolphin ← dolphin not reversed

Not sure if this is the right approach though, or if there's a latent Qt bug.

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 4858.Jun 29 2016, 8:27 PM
broulik retitled this revision from to [KDE Platform Theme] Set application layoutDirection based on locale.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R135 Integration for Qt applications in Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 29 2016, 8:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested changes to this revision.Jun 29 2016, 8:38 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

Looking at QGuiApplication.cpp this is all manner of wrong.

You are right we have a bug, but this really isn't the fix:

I'll take a look.

This revision now requires changes to proceed.Jun 29 2016, 8:38 PM

We don't have a bug. Make sure you have qttranslations build and installed.

If you're using distro packages and they're not installing that, please tell them.

*built and installed

broulik added a subscriber: sitter.Jun 29 2016, 9:02 PM

@sitter I have installed qttranslations5-l10n but it's version 5.5.1 so probably not from neon packages? Or is this because I'm on neon dev ed?

broulik abandoned this revision.Jun 29 2016, 9:41 PM

User also reported that installing this package fixed the issue. It's Arch so probably expected that you need to install everything manually :P but on my Neon setup it should also work out of the box.