Differential D20436

No need to set height to implicitHeight
ClosedPublic
Actions

Authored by jgrulich on Apr 10 2019, 2:37 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R116:5014b50b719f: No need to set height to implicitHeight
Summary

There seem to bug a bug in PlasmaComponents.TextField causing to use different
height depending on missing symbol for echo mode when the symbol is used from
a fallback font. While this was fixed in plasma-framework, we seem to be hitting
same issue when we set height to implicitHeight. It shouldn't be necessary to
set the height.

BUG:399155

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10697
Build 10715: arc lint + arc unit
jgrulich created this revision.Apr 10 2019, 2:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 10 2019, 2:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Apr 10 2019, 2:37 PM
davidedmundson accepted this revision.Apr 10 2019, 7:48 PM
This revision is now accepted and ready to land.Apr 10 2019, 7:48 PM
Closed by commit R116:5014b50b719f: No need to set height to implicitHeight (authored by jgrulich). · Explain WhyApr 11 2019, 6:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55903

View Options

applet/contents/ui/PasswordField.qml

Loading...