Test still passes. I did not try changing the date to 2039 ;)
Details
Details
Diff Detail
Diff Detail
- Repository
- R165 Akonadi
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/server/collectionscheduler.cpp | ||
|---|---|---|
| 224–227 | isn't this still problematic (i.e. the cast to int)? | |
| src/server/collectionscheduler.h | ||
|---|---|---|
| 60 | I'm tempted to use std::chrono::time_point here instead of qint64, which is a better abstraction for time units. You can create a time_point from std::chrono::secods(QDateTime::currentSecsSinceEpoch()), and a difference of two time_points is a std::chrono::duration which can be passed directly to QTimer without having to care about conversion to correct units. If you don't feel up to it (I remember you mentioned you are not much familiar with std::chrono), I'm fine with this version too, I can enhance it later when I get time. Getting this tested and fixed is more important. | |
| autotests/server/collectionschedulertest.cpp | ||
|---|---|---|
| 54–55 | Add using namespace std::chrono_literals to the top, then you can use 4m instead of having to spell out the whole type (also elsewhere in the code). | |