Differential D20359

Fix rating write for mp4 in newer TagLib versions
AbandonedPublic
Actions

Authored by astippich on Apr 7 2019, 4:07 PM.

Details

Reviewers

Summary

This fixes reading and writing rating via the mp4
rate atom. This does not fix reading from "legacy"
rating atoms which stores rating as text.
Fixes CI writing test.

Diff Detail

Repository

R286 KFileMetaData

Branch

taglib_writer_int

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10587
Build 10605: arc lint + arc unit

astippich created this revision.Apr 7 2019, 4:07 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 7 2019, 4:07 PM

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Apr 7 2019, 4:07 PM

Harbormaster completed remote builds in B10587: Diff 55685.Apr 7 2019, 4:07 PM

astippich abandoned this revision.Jun 1 2019, 8:21 AM

Revision Contents
Changeset List

			Path	Packages
M			src/extractors/taglibextractor.cpp (4 lines)
M			src/writers/taglibwriter.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	55685	452edb1		Apr 7 2019, 4:07 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
e3bf878707fb	c8a43680c52e	a54bda6ced33	Alexander Stippich	remove	Apr 6 2019, 6:38 PM
a54bda6ced33	4a8b36c31478	2afbc0eab051	Alexander Stippich	fix access	Apr 6 2019, 6:37 PM
2afbc0eab051	73ccefe09c49	fb22702fd17a	Alexander Stippich	fix extractor	Apr 6 2019, 6:37 PM
fb22702fd17a	214856b59997	452edb1b4c80	Alexander Stippich	Try to fix rating write for newer Taglib versions	Apr 4 2019, 7:10 PM

Fix rating write for mp4 in newer TagLib versionsAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 55685

src/extractors/taglibextractor.cpp

src/writers/taglibwriter.cpp

Fix rating write for mp4 in newer TagLib versions
AbandonedPublic
Actions

Revision Contents
Changeset List