Differential D2034

Set system tray applet to RequiresInput when a popup is showing
ClosedPublic
Actions

Authored by davidedmundson on Jun 28 2016, 1:36 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:7efc1c05d60d: Set system tray applet to RequiresInput when a popup is showing
R120:7efc1c05d60d: Set system tray applet to RequiresInput when a popup is showing
Summary

This matches the base CompactApplet in plasma-desktop.

This prevents the panel autohiding when a popup is still showing.

BUG: 364847

Test Plan

Opened popup panel didn't autohide.
Autohid once popup closed

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 4801.Jun 28 2016, 1:36 PM
davidedmundson retitled this revision from to Set system tray applet to RequiresInput when a popup is showing.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 28 2016, 1:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Jun 28 2016, 2:07 PM

Sneaky. I doing that declaratively and failed :(

Your commit message says "RequiresInput" while you set it to RequiresAttentionStatus.
I think we should also set it to NeedsAttention when there's an SNI demanding attention so the panel briefly pops up?

davidedmundson added a comment.Jun 28 2016, 8:02 PM
In D2034#37316, @broulik wrote:

Sneaky. I doing that declaratively and failed :(

Your commit message says "RequiresInput" while you set it to RequiresAttentionStatus.

Ah yeah, my brain got confused.

I think we should also set it to NeedsAttention when there's an SNI demanding attention so the panel briefly pops up?

Ack, I'll do that in another patch.

davidedmundson updated this revision to Diff 4823.Jun 28 2016, 8:38 PM

ammend comment

broulik accepted this revision.Jun 28 2016, 8:39 PM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Jun 28 2016, 8:39 PM
Closed by commit R120:7efc1c05d60d: Set system tray applet to RequiresInput when a popup is showing (authored by davidedmundson). · Explain WhyJun 29 2016, 9:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4846

View Options

applets/systemtray/package/contents/ui/main.qml

Loading...