Differential D2026

[platforms/drm] If mapping a DrmBuffer for a cursor fails, fallback to software cursor
ClosedPublic
Actions

Authored by graesslin on Jun 28 2016, 8:26 AM.

Details

Reviewers
sebas
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:7ea84cd34642: [platforms/drm] If mapping a DrmBuffer for a cursor fails, fallback to…
Summary

So far the drm platform did not verify whether creating and mapping a
DrmBuffer for a cursor works. This could result in a crash in the worst
case.

This change verfies whether mapping the two cursor buffers works, if
not software cursor is enabled. The code is adjusted to ensure that
none of the cursor buffers is accessed in case software cursor are
enabled.

Please note that right now the drm platform's rendering does not
support software cursors. Thus currently this change results in no
cursor at all. This will be addressed by following patches.

BUG: 364740
FIXED-IN: 5.7

Test Plan

Verfied that it properly falls back to software cursor,
but could not verify that the crash is actually fixed.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4784.Jun 28 2016, 8:26 AM
graesslin retitled this revision from to [platforms/drm] If mapping a DrmBuffer for a cursor fails, fallback to software cursor.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJun 28 2016, 8:26 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Jun 28 2016, 3:35 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Jun 28 2016, 3:35 PM
Closed by commit R108:7ea84cd34642: [platforms/drm] If mapping a DrmBuffer for a cursor fails, fallback to… (authored by graesslin). · Explain WhyJun 29 2016, 6:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4838

View Options

plugins/platforms/drm/drm_backend.cpp

Loading...