[AppletInterface] Check for corona before accessing it
ClosedPublic

Authored by broulik on Apr 4 2019, 7:16 AM.

Details

Summary

On plasmashell shutdown when the panels are destroyed, the available screen geometry changes.
When an applet then accesses screenGeometry in response to that change, it crashes because the corona is already gone.

availableScreenRegion() and availableScreenRect() already checked for this but screenGeometry() did not

Test Plan

No longer have plasma crash in shutdown because of notification popup placement

Ideally, plasmashell didn't bother signalling those changes on shutdown

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 4 2019, 7:16 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 4 2019, 7:16 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 4 2019, 7:16 AM
apol accepted this revision.Apr 4 2019, 7:01 PM
This revision is now accepted and ready to land.Apr 4 2019, 7:01 PM
This revision was automatically updated to reflect the committed changes.