Differential D20238

device: include reapplyConnection() in the interface
ClosedPublic
Actions

Authored by aleksanderm on Apr 3 2019, 9:36 PM.

Details

Reviewers
jgrulich
Group Reviewers
Frameworks
Commits
R282:2d5a66004425: device: include reapplyConnection() in the interface
Summary

The NetworkManager::Device interface was lacking the support for reapplying settings during runtime.

Diff Detail

Repository
R282 NetworkManagerQt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aleksanderm created this revision.Apr 3 2019, 9:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 3 2019, 9:36 PM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aleksanderm requested review of this revision.Apr 3 2019, 9:36 PM
aleksanderm updated this revision to Diff 55379.
jgrulich added inline comments.Apr 4 2019, 5:59 AM
src/device.h
241
  1. const NMVariantMapMap &connection
  1. I would maybe pick a different name, because it doesn't reapply interface, but it reapplies or updates connection. I would maybe use "reapplyConnection()"
aleksanderm updated this revision to Diff 55395.Apr 4 2019, 7:56 AM
aleksanderm retitled this revision from device: include Reapply() in the interface to device: include reapplyConnection() in the interface.
aleksanderm marked an inline comment as done.
jgrulich accepted this revision.Apr 4 2019, 8:26 AM
This revision is now accepted and ready to land.Apr 4 2019, 8:26 AM
Closed by commit R282:2d5a66004425: device: include reapplyConnection() in the interface (authored by aleksanderm, committed by jgrulich). · Explain WhyJul 11 2019, 12:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/device.h (4 lines)
Msrc/device.cpp (6 lines)

Diff 61585

View Options

src/device.h

Loading...
View Options

src/device.cpp

Loading...