Differential D20227

Remove player from known players list when it disappears
ClosedPublic
Actions

Authored by broulik on Apr 3 2019, 1:17 PM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Commits
R856:5940d353366f: Remove player from known players list when it disappears
Summary

When a player item is removed and then added again later we would ignore it since we already know it.

Test Plan

Reloaded YouTube video, can now control it properly again.
The player is removed from DOM and then added again shortly afterwards which we ignore since we already knew the player at this point.

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 3 2019, 1:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 3 2019, 1:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 3 2019, 1:17 PM
broulik edited the test plan for this revision. (Show Details)
fvogt added inline comments.Apr 8 2019, 8:53 AM
extension/content-script.js
416–417

Can be removed now?

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2019, 6:41 PM
Closed by commit R856:5940d353366f: Remove player from known players list when it disappears (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/content-script.js (6 lines)

Diff 55852

View Options

extension/content-script.js

Loading...