Fix uninitialized memory read in KZip
ClosedPublic

Authored by aacid on Apr 2 2019, 5:17 PM.

Details

Summary

We were passing handledextralen instead of n to parseExtraField

We could also do a n < parseExtraField check earlier and fail, but given that parseExtraField always returns true and it has good checks for not over-reading from the buffer it seemed better just to pass n and let it parse as much as possible

Diff Detail

Repository
R243 KArchive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Apr 2 2019, 5:17 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 2 2019, 5:17 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Apr 2 2019, 5:17 PM
aacid added a subscriber: dfaure.Apr 2 2019, 5:17 PM
dfaure accepted this revision.Apr 2 2019, 6:02 PM
This revision is now accepted and ready to land.Apr 2 2019, 6:02 PM
This revision was automatically updated to reflect the committed changes.