Differential D2017

Speak distance info ("In 200 meters, turn right") in navigation instructions, without abusing the filenames of the audio files
ClosedPublic
Actions

Authored by sanjibanb on Jun 26 2016, 9:59 PM.

Details

Reviewers
nienhueser
rahn

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
sanjibanb updated this revision to Diff 4754.Jun 26 2016, 9:59 PM
sanjibanb retitled this revision from to Add distance information in navigation instructions, and do this without abusing the filenames of the audio files.
sanjibanb updated this object.
sanjibanb edited the test plan for this revision. (Show Details)
sanjibanb added reviewers: nienhueser, rahn.
sanjibanb set the repository for this revision to R34 Marble.
sanjibanb added a project: Marble.
sanjibanb added a subscriber: Marble.
sanjibanb updated this revision to Diff 4756.Jun 26 2016, 11:38 PM
sanjibanb retitled this revision from Add distance information in navigation instructions, and do this without abusing the filenames of the audio files to Speak distance info ("In 200 meters, turn right") in navigation instructions, without abusing the filenames of the audio files.Jun 27 2016, 8:21 AM
nienhueser edited edge metadata.Jul 1 2016, 7:12 PM

I think we can also remove m_speakerEnabled and the "ListEnd" / "AppPositive" cases in a subsequent commit, but let's first push this one now.

nienhueser accepted this revision.Jul 1 2016, 7:12 PM
nienhueser edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 7:12 PM
sanjibanb closed this revision.Jul 1 2016, 7:20 PM

Thanks. Will remove m_speakerEnabled and the "ListEnd" / "AppPositive" cases in the next commit. Pushed this one for now.

Revision Contents
Changeset List

Diff 4756

View Options

src/apps/marble-maps/NavigationManager.qml

Loading...
View Options

src/lib/marble/declarative/Navigation.cpp

Loading...
View Options

src/lib/marble/routing/VoiceNavigationModel.cpp

Loading...