Differential D2010

On Wayland never try to create a WindowPixmap from an X11 pixmap
ClosedPublic
Actions

Authored by graesslin on Jun 26 2016, 2:29 PM.

Details

Reviewers
sebas
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:f79c3f244d57: On Wayland never try to create a WindowPixmap from an X11 pixmap
Summary

Our Wayland compositors cannot composite an X11 pixmap. Thus even
if we succeed in creating the pixmap, the changes would not get to
the scene. The code allowed for situation where a surface is not yet
set to fall back to the X11 code path. This can happen for XWayland
windows.

Test Plan

Crash in xclipboardsynctest without the change

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4739.Jun 26 2016, 2:29 PM
graesslin retitled this revision from to On Wayland never try to create a WindowPixmap from an X11 pixmap.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma on Wayland, KWin.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJun 26 2016, 2:29 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Jun 28 2016, 3:28 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Jun 28 2016, 3:28 PM
Closed by commit R108:f79c3f244d57: On Wayland never try to create a WindowPixmap from an X11 pixmap (authored by graesslin). · Explain WhyJun 29 2016, 7:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mscene.cpp (3 lines)

Diff 4841

View Options

scene.cpp

Loading...