Bug 363910 [WACOM] Brush freezes after lifting stylus pen away from tablet
ClosedPublic

Authored by beelzy on Jun 25 2016, 7:21 PM.

Details

Reviewers
rempt
Summary

This patch fixes issues with the brush outline not updating position properly so that it is at least similar to the way it works with the regular mouse. There are still issues with the brush outline lagging, even with the mouse, but at least it works.
EDIT: That lag might actually just be specific to the OpenGL3 branch I was working on. Your mileage may vary.
Unsure if this fix will have consequences for non-Wacom tablets on OSX, but the main problems appear to be that the eventEater is setup to eat any mouse events that are synthesized by Qt (and it does appear eatSyntheticEvents is active). Unfortunately, any of these mouse move events from the tablet after a brush stroke are considered synthesized by Qt. The other issue is that after the end of the stroke, the call to ignore cursor events is not properly disabled in the Leave event, but appears to work when deactivating ignore cursor events in TabletRelease.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
beelzy updated this revision to Diff 4729.Jun 25 2016, 7:21 PM
beelzy retitled this revision from to Bug 363910 [WACOM] Brush freezes after lifting stylus pen away from tablet.
beelzy updated this object.
beelzy edited the test plan for this revision. (Show Details)
beelzy added a reviewer: rempt.
beelzy set the repository for this revision to R37 Krita.
beelzy added a project: Krita.
Restricted Application added a subscriber: woltherav. ยท View Herald TranscriptJun 25 2016, 7:21 PM
beelzy updated this object.Jun 25 2016, 7:27 PM
beelzy updated this object.Jun 25 2016, 7:40 PM
rempt edited edge metadata.Jul 2 2016, 9:09 AM

Hm, with this patch, I actually get the zoom in on approaching the tablet bug again :-(

beelzy added a comment.Jul 4 2016, 9:55 AM

Is it this bug? https://bugs.kde.org/show_bug.cgi?id=364173

Appears not to be fixed yet. I'd only really be concerned if the wheel input events for canvas zoom are disabled or you apply the patch and it still activates zoom.

rempt accepted this revision.Jul 18 2016, 6:11 AM
rempt edited edge metadata.
This revision is now accepted and ready to land.Jul 18 2016, 6:12 AM
aacid closed this revision.Feb 26 2017, 11:16 PM
aacid added a subscriber: aacid.

This seems to have been commited.