Configure shift key = snap to axis in all tools

Authored by abrahams on Jun 25 2016, 1:01 PM.



Affects move tool, path manipulation tool, shape tool & assistant tool.

Also add "alt" in the move tool for precision move.

BUG: 332526

Diff Detail

R37 Krita
shift-snap (branched from master)
No Linters Available
No Unit Test Coverage
abrahams updated this revision to Diff 4719.Jun 25 2016, 1:01 PM
abrahams retitled this revision from to Configure shift key = snap to axis in all tools.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added a reviewer: Krita.
abrahams updated this revision to Diff 4774.Jun 27 2016, 6:17 PM

Fix typos and restore some comments

rempt added a subscriber: rempt.Jun 28 2016, 7:52 AM

Building it now...

rempt added a comment.Jun 28 2016, 8:26 AM

Um, I must either be testing the wrong build or something, but for the move tool, the snap to axis still is on CTRL? I'm not sure what I'm doing wrong here...

Ah, got it. For, for instance the move tool, click, then press shift works, but I guess shift-then-click is more natural -- like it works for ctrl-click.

abrahams updated this revision to Diff 4808.Jun 28 2016, 4:10 PM

Fix Shift+Click for move tool.

Also clarify the "AlternateAction" behavior.

Okay, now the tool doesn't just ignore shift then click.

Turns out this was due to an undocumented feature. Ctrl+right click toggles between "move current layer" and "move layer with content." Who knew?

rempt added a comment.Jun 28 2016, 6:42 PM

Not even Wolthera knew that :-)

Is this acceptable?

rempt added a comment.Jun 29 2016, 8:08 PM

I'm sorry, I was away for most of the day, so I haven't actually re-tested your patch. If you're sure the move tool is fixed (and I guess you are...) then feel free to push: I won't be able to test it until Tuesday; tomorrow and Friday are day-job-days, this weekend my dad is visiting and Monday is a day-job day again :-(

So, go ahead and push if you're confident: the code is fine and the goal is fine, too.

rempt accepted this revision.Jun 30 2016, 6:35 PM
rempt added a reviewer: rempt.

Ah, I managed to find some more time tonight. Seems to me it works perfectly well now!

This revision is now accepted and ready to land.Jun 30 2016, 6:35 PM

No big deal, just was away for the holiday weekend in the US and would have pushed a little while earlier!

This revision was automatically updated to reflect the committed changes.