After Adding Focus , user can directly search after pressing ctrl+h in history sidebar
& ctrl+shift+b in bookmark sidebar
BUG: 393948
Details
Details
- Reviewers
drosca - Group Reviewers
Falkon - Commits
- R875:e66835b4bfd3: Added focus for searchbar in history sidebar & bookmark sidebar
Diff Detail
Diff Detail
- Repository
- R875 Falkon
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
oh I have mixed tab n spaces that's why they were not properly shown here but shows perfectly in sublime , anyways I will correct it.
Comment Actions
One unexpected thing is that it will also focus search line when opening new browser window, not just when manually opening sidebar.
src/lib/sidebar/bookmarkssidebar.cpp | ||
---|---|---|
53 ↗ | (On Diff #54957) | I don't really think there needs to be new method for just this one line. |
54 ↗ | (On Diff #54957) | There is a space after } |
src/lib/sidebar/bookmarkssidebar.h | ||
40 ↗ | (On Diff #54957) | It should be override. |
src/lib/sidebar/bookmarkssidebar.h | ||
---|---|---|
40 ↗ | (On Diff #54957) | ^ |