Make it possible to adjust volume even if it's muted
ClosedPublic

Authored by xuetianweng on Jun 24 2016, 9:21 PM.

Details

Summary

Do not disable the slider if it's muted. It would be more convinient if
it's possible to change muted item volume, just like other mixers. Also
unmute the device/stream if it's muted at the same time.

Unfortunately, I didn't find a way to pretend to be visually disabled,
thus here we use opacity to get the similar visual feedback.

Test Plan

test on my desktop

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
xuetianweng updated this revision to Diff 4713.Jun 24 2016, 9:21 PM
xuetianweng retitled this revision from to Make it possible to adjust volume even if it's muted.
xuetianweng updated this object.
xuetianweng edited the test plan for this revision. (Show Details)
xuetianweng added a reviewer: drosca.
xuetianweng added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 24 2016, 9:21 PM
xuetianweng updated this revision to Diff 4714.Jun 24 2016, 9:26 PM

also do the same thing to kcm's slider

drosca added inline comments.Jun 25 2016, 7:53 AM
src/kcm/package/contents/ui/VolumeSlider.qml
44–45

It should also change opacity when muted here.

How is this presented to the user, visually? I mean when using shortcuts the pop-up (early morning the oms/cms/abbreviation-thing) that shows you sound is muted, or lowered/raised is on screen for just a flicker - which for most are enough since the information is so clear and if you raise/lower it becomes a string of images creating an animation.
Wont adding a third effect sort of make that too complex?

Then the slider: the issue with a slider thats not opaque is that it tend to grey out, a greyed out object is by all norms something you can't interact with.

Not saying that its wrong - just wondering if you guys would want suggestions for alternative ways to present it from us in the VDG?

xuetianweng added inline comments.Jun 26 2016, 3:18 PM
src/kcm/package/contents/ui/VolumeSlider.qml
44–45

I'd rather not, because this is widget style, and disable style is actually "grey out".

drosca edited edge metadata.Jun 26 2016, 4:12 PM

How is this presented to the user, visually? I mean when using shortcuts the pop-up (early morning the oms/cms/abbreviation-thing) that shows you sound is muted, or lowered/raised is on screen for just a flicker - which for most are enough since the information is so clear and if you raise/lower it becomes a string of images creating an animation.
Wont adding a third effect sort of make that too complex?

This is for sliders in ui (applet/kcm), not in OSD as you describe.

I'd rather not, because this is widget style, and disable style is actually "grey out".

The same is in applet, disabled slider is greyed out. And Jens has a point here, it would be better if we come up with a different way to visualize muted stream without changing opacity of sliders (if we want to make them interactive when muted).

In D2000#36954, @drosca wrote:

The same is in applet, disabled slider is greyed out. And Jens has a point here, it would be better if we come up with a different way to visualize muted stream without changing opacity of sliders (if we want to make them interactive when muted).

Actually now I looked at the one in windows, probably opacity makes sense. Shall we do it this way (set opacity) for now, since this is not only about visual but also functionality

xuetianweng updated this revision to Diff 4749.Jun 26 2016, 6:26 PM
xuetianweng edited edge metadata.

also apply opacity to kcm's slider

Shall we do it this way (set opacity) for now

I'd say let's go with it for now, unless VDG has better idea? In any case, this should go into master and not 5.7.

change it against master

xuetianweng marked an inline comment as done.Jun 27 2016, 10:34 PM
drosca accepted this revision.Jun 28 2016, 11:56 AM
drosca edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2016, 11:56 AM
This revision was automatically updated to reflect the committed changes.