Add International Date Line
ClosedPublic

Authored by tandon on Jun 24 2016, 9:20 PM.

Details

Summary

Rendering

Fix for the following issue

  1. Extract the International Date Line from the Geographic Lines file.

The Geographic Lines file for each resolution in the Natural Earth Dataset contains the International Date Line (IDL) as well as the Tropical and Polar Circles and the Equator.
Difficulty: MEDIUM
We ONLY want to use the IDL since we can much more efficiently create the other lines inside our Coordinate Grid plugin. So this task is about extracting/importing the IDL into the tiles for each level as part of our natural earth tile build script.
For the styling a black line should be chosen.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tandon updated this revision to Diff 4712.Jun 24 2016, 9:20 PM
tandon retitled this revision from to Add International Date Line.
tandon updated this object.
tandon edited the test plan for this revision. (Show Details)
tandon added reviewers: nienhueser, rahn.
tandon set the repository for this revision to R34 Marble.
tandon added a project: Marble.
tandon added a subscriber: Marble.
tandon updated this object.Jun 24 2016, 9:28 PM
nienhueser added inline comments.Jun 25 2016, 5:44 AM
src/lib/marble/StyleBuilder.cpp
591

no need for a custom dash pattern (the QVector part at the end) when the line styling is solid.

src/lib/marble/geodata/data/GeoDataFeature.h
422

I'd go for a more descriptive InternationalDateLine

tandon updated this revision to Diff 4723.Jun 25 2016, 2:33 PM
tandon marked 2 inline comments as done.

Edited the styling and changed the name to InternationalDateLine from GeographicLine.

nienhueser accepted this revision.Jun 25 2016, 2:41 PM
nienhueser edited edge metadata.

Looks good.

src/lib/marble/StyleBuilder.cpp
595

The first boolean should be false, it shouldn't be filled (doesn't matter here for the line string, but just in case).

This revision is now accepted and ready to land.Jun 25 2016, 2:41 PM
This revision was automatically updated to reflect the committed changes.