Make attribute getters truly const (and non-const)
ClosedPublic

Authored by dvratil on Mar 21 2019, 2:59 PM.

Details

Summary

Also cleans up the code a little.

This change requires const fixes basically everywhere where the API
is used, please do NOT merge this until everything else has been
adjusted.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Mar 21 2019, 2:59 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 21 2019, 2:59 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.Mar 21 2019, 2:59 PM
dvratil updated this revision to Diff 54491.Mar 21 2019, 3:32 PM
  • Handle markAttributeChanged() detaching
This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2019, 4:33 PM
This revision was automatically updated to reflect the committed changes.
dvratil reopened this revision.Mar 21 2019, 4:58 PM

Silly phabricator, I just pushed the code to a devel branch :)

http://www.davidfaure.fr/2019/0001-Make-attribute-getters-truly-const-and-non-const.patch rebased (and conflicts merged) after my branch fix, + made value() const in entityannotationsattribute.h, needed by pimcommon.

dfaure accepted this revision.Mar 24 2019, 9:20 PM

I ported all other PIM modules, let's push this.

This revision is now accepted and ready to land.Mar 24 2019, 9:20 PM
This revision was automatically updated to reflect the committed changes.