Differential D19937

don't connect to lambdas and call slots when you can just call the slots
ClosedPublic
Actions

Authored by sitter on Mar 21 2019, 10:29 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R871:d0974fdc18b4: don't connect to lambdas and call slots when you can just call the slots
Summary

the lambdas were really unnecessary. both deleteLater and restart
are losts, and arg-less ones at that, so instead of using a lambda we can
just connect to the slots directly.

Diff Detail

Repository
R871 DrKonqi
Branch
randomlambdas
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9933
Build 9951: arc lint + arc unit
sitter created this revision.Mar 21 2019, 10:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 21 2019, 10:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Mar 21 2019, 10:29 AM
davidedmundson accepted this revision.Mar 21 2019, 10:56 AM
This revision is now accepted and ready to land.Mar 21 2019, 10:56 AM
Closed by commit R871:d0974fdc18b4: don't connect to lambdas and call slots when you can just call the slots (authored by sitter). · Explain WhyMar 21 2019, 11:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/statusnotifier.cpp (8 lines)

Diff 54471

View Options

src/statusnotifier.cpp

Loading...