Differential D19783

[kitemview] compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Mar 15 2019, 12:49 PM.

Tags

Subscribers

apol, kde-frameworks-devel

Details

Reviewers

dfaure
apol

Commits

R276:8b7bbad43ea2: [kitemview] compile without foreach

Summary

compile without foreach

Test Plan

autotest ok

Diff Detail

Repository

R276 KItemViews

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mlaurent created this revision.Mar 15 2019, 12:49 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 15 2019, 12:49 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mlaurent requested review of this revision.Mar 15 2019, 12:49 PM

Harbormaster completed remote builds in B9622: Diff 53950.Mar 15 2019, 12:49 PM

apol added a subscriber: apol.Mar 15 2019, 6:32 PM

apol added inline comments.

src/kwidgetitemdelegatepool.cpp
136	This one clearly should be using iterators instead of foreach

Use iterator

Harbormaster completed remote builds in B9669: Diff 54016.Mar 16 2019, 2:30 PM

apol accepted this revision.Mar 16 2019, 4:10 PM

This revision is now accepted and ready to land.Mar 16 2019, 4:10 PM

Closed by commit R276:8b7bbad43ea2: [kitemview] compile without foreach (authored by mlaurent). · Explain WhyMar 16 2019, 5:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		.gitignore (21 lines)
M			CMakeLists.txt (3 lines)
M			src/kcategorizedview.cpp (10 lines)
M			src/kextendableitemdelegate.cpp (4 lines)
M			src/ktreewidgetsearchline.cpp (8 lines)
M			src/kwidgetitemdelegate.cpp (16 lines)
M			src/kwidgetitemdelegatepool.cpp (16 lines)
M			tests/kwidgetitemdelegatetest.cpp (8 lines)

Diff 54028

.gitignore

Loading...

CMakeLists.txt

Loading...

src/kcategorizedview.cpp

Loading...

src/kextendableitemdelegate.cpp

Loading...

src/ktreewidgetsearchline.cpp

Loading...

src/kwidgetitemdelegate.cpp

Loading...

src/kwidgetitemdelegatepool.cpp

Loading...

tests/kwidgetitemdelegatetest.cpp

Loading...