Differential D19772

Follow KDE HIG by using ellipis
ClosedPublic
Actions

Authored by ognarb on Mar 14 2019, 10:26 PM.

Details

Reviewers
stikonas
ngraham
Group Reviewers
VDG
Maniphest Tasks
T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG
Commits
R473:c77b09fe37ac: Follow KDE HIG by using ellipis
Summary

See https://hig.kde.org/style/writing/placeholder.html#actions

@stikonas I add you as reviewer because I saw that you are last contributor to KTorrent :D

Test Plan

Build and run

Diff Detail

Repository
R473 KTorrent
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb requested review of this revision.Mar 14 2019, 10:26 PM
ognarb created this revision.
ognarb updated this revision to Diff 54133.Mar 17 2019, 7:00 PM

Use 3 dots instead of the unicode ellipsis

ognarb edited the summary of this revision. (Show Details)Mar 17 2019, 7:03 PM
ognarb added a reviewer: stikonas.
ognarb added a subscriber: stikonas.
ngraham accepted this revision.Mar 17 2019, 9:33 PM
This revision is now accepted and ready to land.Mar 17 2019, 9:33 PM
stikonas accepted this revision.Mar 17 2019, 10:44 PM
Closed by commit R473:c77b09fe37ac: Follow KDE HIG by using ellipis (authored by ognarb). · Explain WhyMar 17 2019, 11:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mktorrent/view/torrentsearchbar.cpp (2 lines)

Diff 54159

View Options

ktorrent/view/torrentsearchbar.cpp

Loading...