Differential D19714

Fixes crash when closing with Detailed Memory Information open
Needs ReviewPublic
Actions

Authored by hallas on Mar 12 2019, 7:29 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

Fixes a crash that occurs if you close KSysGuard with a Detailed Memory
Information window open. The crash is caused by ScriptingHtmlDialog
being freed twice.

Test Plan

Open KSysGuard
Right clock on a process and select Detailed Memory Information
Close the main KSysGuard window by clicking the close button in the title bar

Diff Detail

Repository
R111 KSysguard Library
Branch
fixes_crash_when_closing_with_detailed_memory_usage_open (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9512
Build 9530: arc lint + arc unit
hallas created this revision.Mar 12 2019, 7:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 12 2019, 7:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hallas requested review of this revision.Mar 12 2019, 7:29 PM
hallas added a comment.Apr 11 2019, 5:36 PM

Ping - anyone?

davidedmundson added a comment.Apr 11 2019, 6:10 PM

I don't have webkit built, so can't test this, but I have one concern:

  • refreshAction is owned by mScriptingHtmlDialog
  • when refresh action is triggered we will delete mScriptingHtmlDialog immediately
  • which means we've now killed refreshAction whilst it's triggering an event

Revision Contents
Changeset List

PathPackages
Mprocessui/scripting.cpp (3 lines)

Diff 53754

View Options

processui/scripting.cpp

Loading...